Fix issue in extraCommandArgs field #1541
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rizwana777
force-pushed
the
issue-5200
branch
6 times, most recently
from
c2b7eb0
to
e8ed105
Compare
saumeya
reviewed
Sep 11, 2024
| // If this flag already exists in cmd, skip it | ||
| if _, exists := existingArgs[arg]; exists { | ||
| if i+1 < len(extraArgs) && !strings.HasPrefix(extraArgs[i+1], "--") { | ||
| i++ // Skip the associated value |
There was a problem hiding this comment.
What if an existing flag is added with a new value, will that also be skipped?
There was a problem hiding this comment.
yes, it is skipped
There was a problem hiding this comment.
Is that the expected behavior? what if the user wants to change the current flag value?
There was a problem hiding this comment.
based on the existing unit test https://github.com/argoproj-labs/argocd-operator/blob/master/controllers/argocd/deployment_test.go#L1304 which is updating existing cmd i.e --redis command, I think this is expected behaviour, I might be wrong and open for suggestions
saumeya
reviewed
Sep 11, 2024
| }, | ||
| deployment)) | ||
|
|
||
| // Non-duplicate argument "--newarg" should be added, duplicate "--redis" is ignored |
There was a problem hiding this comment.
This is probably a typo of --redis, I don't see that in the test case.
Signed-off-by: Rizwana777 <[email protected]>
Rizwana777
force-pushed
the
issue-5200
branch
from
e8ed105
to
06d0795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA - https://issues.redhat.com/browse/GITOPS-5200