feat(argo-cd): Adding ARGOCD_API_SERVER_REPLICAS environment variable #2750
+5
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdun1013
requested review from
mbevc1,
mkilchhofer,
yu-croco,
jmeridth,
pdrastil and
tico24
as code owners
bdun1013
changed the title
pdrastil
reviewed
Jun 6, 2024
| @@ -76,6 +76,10 @@ spec: | |||
| {{- with (concat .Values.global.env .Values.server.env) }} | |||
| {{- toYaml . | nindent 10 }} | |||
| {{- end }} | |||
| {{- if not .Values.server.autoscaling.enabled }} | |||
There was a problem hiding this comment.
This condition enables HPA that scales server between min and max number of replicas. It's not a fixed a number stated below.
For HPA it should be probably minimum number of replicas, without HPA this could be fixed number of replicas defined as of now.
Ref: https://argo-cd.readthedocs.io/en/stable/operator-manual/high_availability/#argocd-server
bdun1013
force-pushed
the
2749-server-replicas-env-var
branch
from
b07d4ec
to
d8f92a2
Compare
bdun1013
force-pushed
the
2749-server-replicas-env-var
branch
2 times, most recently
from
3bd776a
to
ca39977
Compare
bdun1013
force-pushed
the
2749-server-replicas-env-var
branch
from
ca39977
to
4a51721
Compare
…to server when autoscaling is not enabled Signed-off-by: Brian Dunnigan <[email protected]>
bdun1013
force-pushed
the
2749-server-replicas-env-var
branch
from
dfc794e
to
ff411cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2749 - Adding ARGOCD_API_SERVER_REPLICAS environment variable to server when autoscaling is not enabled
Checklist: