Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(experiments): add ability to set service port mappings #3544

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

feat(experiments): add ability to set service port mappings #3544

wants to merge 2 commits into from

Conversation

yohanb
Copy link
Contributor

@yohanb yohanb commented Apr 29, 2024

Adds enhancement #3428

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this is a chore.
  • The title of the PR is (a) conventional with a list of types and scopes found here, (b) states what changed, and (c) suffixes the related issues number. E.g. "fix(controller): Updates such and such. Fixes #1234".
  • I've signed my commits with DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My builds are green. Try syncing with master if they are not.
  • My organization is added to USERS.md.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

Go Published Test Results

2 160 tests   2 160 ✅  2m 53s ⏱️
  119 suites      0 💤
    1 files        0 ❌

Results for commit 4a99969.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 29, 2024 •
edited
Loading

E2E Tests Published Test Results

  4 files    4 suites   3h 29m 2s ⏱️
111 tests  98 ✅  6 💤  7 ❌
458 runs  420 ✅ 24 💤 14 ❌

For more details on these failures, see this check.

Results for commit 4a99969.

♻️ This comment has been updated with latest results.

@yohanb yohanb force-pushed the feat_experiment_port_mappings branch 2 times, most recently from 9f31bbd to ed8aa29 Compare April 29, 2024 17:08
@codecov Codecov
Copy link

codecov bot commented Apr 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.75000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.85%. Comparing base (bfef7f0) to head (d45468f).

Files Patch % Lines
rollout/experiment.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   83.86%   83.85%   -0.01%     
==========================================
  Files         163      163              
  Lines       18560    18577      +17     
==========================================
+ Hits        15565    15578      +13     
- Misses       2121     2123       +2     
- Partials      874      876       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yohanb yohanb force-pushed the feat_experiment_port_mappings branch from ed8aa29 to 74a6051 Compare April 29, 2024 17:14
@yohanb
Copy link
Contributor Author

yohanb commented Apr 30, 2024

Codecov Report

Attention: Patch coverage is 81.25000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 78.20%. Comparing base (8405f2e) to head (74a6051).
Report is 99 commits behind head on master.

Files Patch % Lines
experiments/experiment.go 85.18% 3 Missing and 1 partial ⚠️
rollout/experiment.go 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3544      +/-   ##
==========================================
- Coverage   81.83%   78.20%   -3.64%     
==========================================
  Files         135      158      +23     
  Lines       20688    18414    -2274     
==========================================
- Hits        16931    14400    -2531     
- Misses       2883     3105     +222     
- Partials      874      909      +35

☔ View full report in Codecov by Sentry. 📢 Have feedback on the report? Share it here.

👋 @zachaller not sure why the code coverage dropped. I added an e2e test that covers the new code paths 🤔

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

meeech
meeech reviewed Aug 27, 2024
View reviewed changes
docs/features/experiment.md Outdated
@@ -57,6 +57,11 @@ spec:
service:
# Name of the Service (optional). If omitted, service: {} would also be acceptable.
name: service-name
# Service port mappings(optional). This is useful when the container port is different from the desired service port.
# If omitted, the port will be mapped to the container port.
portMappings:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not just go with ports to keep it consistent with how we write a service in k8s?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with this, we need to be forward thinking in possibly embeding the whole service spec and to do that we would want to match it's api.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2233 (comment)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the review guys. I'll have a look asap.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meeech @zachaller done! I amended my previous commits.

@zachaller zachaller self-assigned this Aug 27, 2024
@yohanb yohanb force-pushed the feat_experiment_port_mappings branch from 4a99969 to d45468f Compare August 28, 2024 15:27
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

Published E2E Test Results

4 files  4 suites   0s ⏱️
1 tests 0 ✅ 0 💤 1 ❌
0 runs  -4 ✅ 0 💤 4 ❌

For more details on these failures, see this check.

Results for commit 1a0a89a.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Aug 28, 2024 •
edited
Loading

Published Unit Test Results

2 261 tests   2 259 ✅  2m 56s ⏱️
  128 suites      0 💤
    1 files        2 ❌

For more details on these failures, see this check.

Results for commit 1a0a89a.

♻️ This comment has been updated with latest results.

@yohanb yohanb force-pushed the feat_experiment_port_mappings branch from d45468f to 5b4a1a7 Compare August 28, 2024 21:56
@yohanb yohanb force-pushed the feat_experiment_port_mappings branch 3 times, most recently from 629c3bd to 9b86988 Compare August 29, 2024 00:01
@yohanb yohanb force-pushed the feat_experiment_port_mappings branch from 9b86988 to 1a0a89a Compare August 29, 2024 00:08
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Aug 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meeech meeech Awaiting requested review from meeech

@zachaller zachaller Awaiting requested review from zachaller

At least 1 approving review is required to merge this pull request.

Assignees

@zachaller zachaller

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yohanb @meeech @zachaller