Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(trafficrouting): support ingresses with multiple service ports in TrafficRouting.ALB spec #3551

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

test(trafficrouting): add more unit-tests for ALB traffic routing to …

0179f8b
Select commit
Loading
Failed to load commit list.
Open

feat(trafficrouting): support ingresses with multiple service ports in TrafficRouting.ALB spec #3551

test(trafficrouting): add more unit-tests for ALB traffic routing to …
0179f8b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 17, 2024 in 1s

83.99% (+0.10%) compared to b8a9bf5

View this Pull Request on Codecov

83.99% (+0.10%) compared to b8a9bf5

Details

Codecov Report

Attention: Patch coverage is 99.40476% with 1 line in your changes missing coverage. Please review.

Project coverage is 83.99%. Comparing base (b8a9bf5) to head (0179f8b).

Files with missing lines Patch % Lines
rollout/trafficrouting/alb/alb.go 98.82% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3551      +/-   ##
==========================================
+ Coverage   83.88%   83.99%   +0.10%     
==========================================
  Files         163      163              
  Lines       18560    18609      +49     
==========================================
+ Hits        15569    15630      +61     
+ Misses       2119     2112       -7     
+ Partials      872      867       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.