-
Notifications
You must be signed in to change notification settings - Fork 847
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: rollout should skip timeout when paused #3711
base: master
Are you sure you want to change the base?
fix: rollout should skip timeout when paused #3711
Conversation
Go Published Test Results2 171 tests 2 171 ✅ 2m 54s ⏱️ Results for commit b996a85. ♻️ This comment has been updated with latest results. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3711 +/- ##
==========================================
+ Coverage 83.86% 83.87% +0.01%
==========================================
Files 163 163
Lines 18560 18560
==========================================
+ Hits 15565 15567 +2
+ Misses 2121 2120 -1
+ Partials 874 873 -1 ☔ View full report in Codecov by Sentry. |
E2E Tests Published Test Results 4 files 4 suites 3h 23m 50s ⏱️ Results for commit b996a85. ♻️ This comment has been updated with latest results. |
Hi @zachaller, could you help to review this PR? This issue really trouble us when user did not promote Rollouts in certain timeframe(progressDeadlineSeconds) and controller will mark it as timeout, hence ArgoCD will mark it as |
Can you add a unit or e2e test for this? |
Sure, will add it. |
b996a85
to
6b73de9
Compare
Published E2E Test Results 4 files 4 suites 3h 17m 32s ⏱️ For more details on these failures, see this check. Results for commit 648aa25. ♻️ This comment has been updated with latest results. |
Published Unit Test Results2 277 tests 2 277 ✅ 2m 59s ⏱️ Results for commit 648aa25. ♻️ This comment has been updated with latest results. |
e9cce70
to
afaf96e
Compare
Hi @zachaller , UTs have been added. Please review it. Thank you. |
Signed-off-by: Li Wang <[email protected]>
Signed-off-by: Li Wang <[email protected]>
04bd09b
to
648aa25
Compare
Quality Gate passedIssues Measures |
fix for issue #3534
Checklist:
"fix(controller): Updates such and such. Fixes #1234"
.