Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: check-downstream-compiles crate #71

Merged
merged 3 commits into from
Aug 12, 2024
Merged

feat: check-downstream-compiles crate #71

merged 3 commits into from
Aug 12, 2024

Conversation

samuelburnham
Copy link
Member

@samuelburnham samuelburnham commented Aug 9, 2024 •
edited
Loading

Switches from hacky Bash scripts to a Rust crate with equivalent functionality.

Successful runs: https://github.com/argumentcomputer/sphinx/actions/runs/10326798363/job/28590931921?pr=145

@samuelburnham samuelburnham force-pushed the check-downstream-compiles-crate branch from 4a55fc6 to 4918af8 Compare August 9, 2024 22:10
@samuelburnham samuelburnham force-pushed the check-downstream-compiles-crate branch 2 times, most recently from e2d4ff6 to 145672f Compare August 9, 2024 23:08
@samuelburnham samuelburnham marked this pull request as ready for review August 9, 2024 23:09
@samuelburnham samuelburnham mentioned this pull request Aug 9, 2024
Merged
@samuelburnham samuelburnham force-pushed the check-downstream-compiles-crate branch from 145672f to 6c3782d Compare August 10, 2024 02:26
huitseeker
huitseeker approved these changes Aug 11, 2024
View reviewed changes
Copy link
Member

@huitseeker huitseeker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent!

wwared
wwared approved these changes Aug 12, 2024
View reviewed changes
Copy link
Member

@wwared wwared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Much less confusing than the bash scripts

@samuelburnham samuelburnham added this pull request to the merge queue Aug 12, 2024
Merged via the queue into main with commit cdac576 Aug 12, 2024
2 checks passed
@samuelburnham samuelburnham deleted the check-downstream-compiles-crate branch August 12, 2024 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@huitseeker huitseeker huitseeker approved these changes

@wwared wwared wwared approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samuelburnham @huitseeker @wwared