Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(build): add Makefile, Dockerfile, scripts; bump Hugo to 0.74.3; add build targets to netlify.toml #247

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

aimeeu
Copy link
Contributor

@aimeeu aimeeu commented Oct 7, 2020

Modified from github.com/kubernetes/website

  • Update Dockerfile for Hugo
  • Add Makefile with build targets
  • Copy scripts directory from kubernetes/website/scripts
  • Modify netlify.toml

Local builds and Netlify deploy previews should display drafts and posts with a future date (we don't currently have those but might later)

To build locally:
make serve

To build the container and run it:
make container-image
make container-serve

Note: I get a permission error when executing make container-image: /bin/sh: scripts/hash-files.sh: Permission denied do not know why yet

Setting this to Draft until I figure out the container local permission issue and also how to configure the build in Netlify - I don't think I have to do anything since it should read the build command from netlify.toml.

@aimeeu aimeeu requested a review from a team as a code owner October 7, 2020 21:14
@aimeeu aimeeu marked this pull request as draft October 7, 2020 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant