Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update splash screen logic #10808

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

MounirDhahri
Copy link
Member

Description

This PR makes the following changes:

  • Update react-native-bootsplash to the latest version on both Android and iOS.
  • Update iOS splash screen dismissal logic
    • Old logic: the splash screen dismisses as soon as js is bundled
    • New logic: align with the industry best practices and react-native-bootsplash and dismiss the splash screen from the JS side.

PR Checklist

  • I have tested my changes on iOS and Android.
  • I hid my changes behind a feature flag, or they don't need one.
  • I have included screenshots or videos, or I have not changed the UI.
  • I have added tests, or my changes don't require any.
  • I added an app state migration, or my changes do not require one.
  • I have documented any follow-up work that this PR will require, or it does not require any.
  • I have added a changelog entry below, or my changes do not require one.

To the reviewers 👀

  • I would like at least one of the reviewers to run this PR on the simulator or device.
Changelog updates

Changelog updates

Cross-platform user-facing changes

iOS user-facing changes

Android user-facing changes

Dev changes

  • update splash screen logic - mounir

Need help with something? Have a look at our docs, or get in touch with us.

@MounirDhahri MounirDhahri self-assigned this Sep 18, 2024
@ArtsyOpenSource
Copy link
Contributor

ArtsyOpenSource commented Sep 18, 2024

Warnings
⚠️

❌ **It seems like you added some non WebP images to Eigen, please convert them to WebPs using source images/script.sh script **

Generated by 🚫 dangerJS against cbc129c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants