Dual sim detection #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch: LA.BR.1.3.3-02720-8976.0
* Apparently there are two variants of XT1625 , one Msim and another Ssim. Our team mate has the single sim variant.So support it until I get more info on the variants.
Detect dualsim correctly for XT1622
As Motorola offers single/dual-sim and different memory options on each model, the checkes are moved outside model selection
As Motorola offers single/dual-sim and different memory options on each model, the checkes are moved outside model selection
…ice_motorola_athene-2 into minidude2012-patch-2
KoffieNu
force-pushed
the
cm-13.0
branch
2 times, most recently
from
96a28d9
to
5c23e73
Compare
Single sim settings copied from XT1622 single sim stock properties (getprop command)
KoffieNu
force-pushed
the
cm-13.0
branch
2 times, most recently
from
f8e7e4a
to
97696f2
Compare
Inspired by boulzordev his init script version in github boulzordev/android_device_motorola_msm8952-common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi ashwinr64,
I've added the dual sim detection and it works. I also moved it outside the mode tree, as teh XT1622 is in both versions shipped. Also the XT1622 is shipped with 2 and 3 GB mem. This check is also moved outside the model decision tree. (limiting choice between 2G and other models, as those are 3 and 4G)
I've simplified the tree in XT162x and XT164x, as I couldn't find any major differences between the athene and athene_f tree other then those. This need to be checked.
Personally I think the community is better off with a separate tree for both models (athene and athene_f), so you can limit the amount of useless firmware and binaries for the athene tree. Biggest issue left is ringtone, I'm currently testing that. (patch included. unsure if this is what is needed, if so, vendor tree needs to be adapted as well)
With regards,
KoffieNu