Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove legacy container implementation #215

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

albertogasparin
Copy link
Collaborator

@albertogasparin albertogasparin commented Sep 8, 2023

Legacy implementation contains a potential memory leak and we don't need it anymore.

@@ -186,13 +21,6 @@ export function createContainer(
const Store = StoreOrOptions;
const dn = displayName || `Container(${Store.key.split('__')[0]})`;

return class extends Container {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

@albertogasparin albertogasparin merged commit c86f903 into master Sep 8, 2023
2 checks passed
@albertogasparin albertogasparin deleted the fix/remove-legacy-container branch September 8, 2023 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants