DXCDT-474: Integrate with the go-auth0 beta branch #652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergiught
force-pushed
the
patch/go-sdk-beta
branch
from
f8aa35d
to
3a57771
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## v1 #652 +/- ##
=====================================
Coverage ? 86.51%
=====================================
Files ? 80
Lines ? 11720
Branches ? 0
=====================================
Hits ? 10139
Misses ? 1209
Partials ? 372 |
sergiught
commented
Jun 23, 2023
| @@ -32,7 +32,6 @@ data "auth0_client" "some-client-by-id" { | |||
|
|
|||
| ### Read-Only | |||
|
|
|||
| - `addons` (List of Object) Addons enabled for this client and their associated configurations. (see [below for nested schema](#nestedatt--addons)) | |||
There was a problem hiding this comment.
Addons are temporarily removed within the v1 branch as to not include too many changes within this PR. The next follow up PR will be adjusting the client addons schema with the proper terraform schema and go types.
| } | ||
|
|
||
| return api.ResourceServer.Stream(fn, management.IncludeFields("id", "name")) |
There was a problem hiding this comment.
The Stream func got removed from v1 beta go-auth0.
sergiught
commented
Jun 23, 2023
| @@ -87,17 +89,20 @@ func userAgent(terraformVersion *string) string { | |||
|
|
|||
| // authenticationOption computes the desired authentication option for the *management.Management client. | |||
| func authenticationOption(clientID, clientSecret, apiToken, audience string) management.Option { | |||
| ctx := context.Background() | |||
There was a problem hiding this comment.
This seems to be needed as otherwise we're gonna have the context canceled after a few API calls as the CRUD funcs will do a ctx.Done() call.
|
E2E tests are passing against this branch: https://github.com/auth0/terraform-provider-auth0/actions/runs/5358821368/jobs/9721626291 |
sergiught
force-pushed
the
v1
branch
2 times, most recently
from
54a2007
to
2416438
Compare
* Initial commit, tests passing for auth0 connection * Making strategy inferred, expanding entire connection now * types file into base * Removing notes * Renaming package name * Generated docs * Moving into existing connection package * Regenerating docs, additional renamings * Regenerating docs * Recording test * Cloning schema * Pulling-out description into parameter * Fixing flattening of configuration property * Fixing warning text * Renaming package name --------- Co-authored-by: Will Vedder <[email protected]>
This reverts commit e600c0e.
sergiught
force-pushed
the
patch/go-sdk-beta
branch
from
ca73c42
to
565a0c4
Compare
Widcket
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🔧 Changes
The go-auth0 SDK is scheduled for an upcoming v1-beta release. In order to pre-emptively test some of the major changes introduced we are temporarily pointing to the latest commit on the beta branch https://github.com/auth0/go-auth0/tree/beta and going forward with updating our codebase to prepare for it. The integration is happening only on our v1 branch and this will not get released until we can update our go.mod to point to a proper v1 tag for the go-auth0 SDK.
To note that considering the go-auth0 v1 beta introduced type changes to the client addons, we are temporarily removing them from our code base within the v1 branch. The next PR after this one will be the work to re-introduce the client addons with proper types and an updated terraform config schema.
📚 References
🔬 Testing
📝 Checklist