-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): update storage outputs class for multi-bucket support #5476
base: multi-bucket
Are you sure you want to change the base?
Changes from 4 commits
13d6723
c5c0438
f22dd48
cc6c55b
b6f8719
66ad860
3fc0ce9
9114206
a17b602
e7906c7
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,37 @@ | ||||||
// Copyright Amazon.com, Inc. or its affiliates. All Rights Reserved. | ||||||
// SPDX-License-Identifier: Apache-2.0 | ||||||
|
||||||
import 'package:amplify_core/amplify_core.dart'; | ||||||
|
||||||
part 'bucket_output.g.dart'; | ||||||
|
||||||
@zAmplifyOutputsSerializable | ||||||
class BucketOutput | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
with AWSEquatable<BucketOutput>, AWSSerializable, AWSDebuggable{ | ||||||
|
||||||
const BucketOutput({required this.name, required this.bucketName, required this.awsRegion}); | ||||||
|
||||||
factory BucketOutput.fromJson(Map<String, Object?> json) => | ||||||
_$BucketOutputFromJson(json); | ||||||
|
||||||
final String name; | ||||||
|
||||||
final String bucketName; | ||||||
|
||||||
final String awsRegion; | ||||||
|
||||||
@override | ||||||
List<Object?> get props => [ | ||||||
name, | ||||||
bucketName, | ||||||
awsRegion, | ||||||
]; | ||||||
|
||||||
@override | ||||||
String get runtimeTypeName => 'BucketOutput'; | ||||||
|
||||||
@override | ||||||
Object? toJson() { | ||||||
return _$BucketOutputToJson(this); | ||||||
} | ||||||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Question: I see the test data has been updated, but are the tests written in a way that validate the new functionality too? Do they need to be updated? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is a good question, since multiple buckets are optional, I think we should validate that it works when only one bucket is supplied too. I'll check this out There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I've verified that the test does work properly when only a single bucket is supplied and that the test itself actually validates the new function for multi-bucket support |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing doc comments https://dart.dev/effective-dart/documentation#doc-comments.