Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: custom SSL CA support for SQL data sources #7802

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

palpatim
Copy link
Member

@palpatim palpatim commented Jul 3, 2024

Description of changes:

Add documentation for specifying custom SSL CA certificate bundle for SQL Lambda data sources.

image

Related GitHub issue #, if available:

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

This should not be submitted until aws-amplify/amplify-backend#1696 is released.

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

```

The Lambda function will then use the specified root CA to validate connections to the database.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we callout that the size of the file must be <= 4 KB?

sundersc
sundersc previously approved these changes Jul 3, 2024
Copy link
Contributor

@hbuchel hbuchel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you merge in latest from main, it includes a fix for the accessibility violations on this page which will unblock the checks.

@sundersc sundersc marked this pull request as ready for review August 29, 2024 17:20
@sundersc sundersc requested a review from a team as a code owner August 29, 2024 17:20
@palpatim
Copy link
Member Author

Force-pushed a rebase from main

@reesscot reesscot merged commit e72eead into main Aug 29, 2024
12 checks passed
@reesscot reesscot deleted the palpatim/custom-ssl-cert branch August 29, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants