Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(analytics): add update iam policy section to existing resources page for flutter and natives #7914

Merged
merged 1 commit into from
Aug 30, 2024

Conversation

NikaHsn
Copy link
Member

@NikaHsn NikaHsn commented Aug 23, 2024

Description of changes:

  • update the anlaytics' use existing aws resources page to add a section for updating iam policy for flutter and natives. this section has already existed for js but was missing for flutter and natives.

Related GitHub issue #, if available:

aws-amplify/amplify-flutter#5356

Instructions

If this PR should not be merged upon approval for any reason, please submit as a DRAFT

Which product(s) are affected by this PR (if applicable)?

  • amplify-cli
  • amplify-ui
  • amplify-studio
  • amplify-hosting
  • amplify-libraries

Which platform(s) are affected by this PR (if applicable)?

  • JS
  • Swift
  • Android
  • Flutter
  • React Native

Please add the product(s)/platform(s) affected to the PR title

Checks

  • Does this PR conform to the styleguide?

  • Does this PR include filetypes other than markdown or images? Please add or update unit tests accordingly.

  • Are any files being deleted with this PR? If so, have the needed redirects been created?

  • Are all links in MDX files using the MDX link syntax rather than HTML link syntax?

    ref: MDX: [link](https://docs.amplify.aws/)
    HTML: <a href="https://docs.amplify.aws/">link</a>

When this PR is ready to merge, please check the box below

  • Ready to merge

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@NikaHsn NikaHsn requested review from hdworld11 and a team as code owners August 23, 2024 17:50
@@ -97,4 +98,3 @@ Amazon Pinpoint requires an AWS Identity and Access Management (IAM) policy in o
}
```

</InlineFilter>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please explain why this moved?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the ## Update your IAM Policy section is applicable to all platforms. the JS platform section should start after the ## Update your IAM Policy

@NikaHsn NikaHsn merged commit a85dde6 into main Aug 30, 2024
12 checks passed
@NikaHsn NikaHsn deleted the fix/analytics-existing-resources-iam-policy branch August 30, 2024 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants