Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(protocoltests): add S3 Client #6178

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

trivikr
Copy link
Member

@trivikr trivikr commented Jun 7, 2024

Issue

Internal JS-5057

Description

Adds S3 client in RestXml Protocol tests

Testing

CI

Additional context

Previous attempt in #5166


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@trivikr

This comment was marked as outdated.

@trivikr trivikr force-pushed the aws-protocoltests-s3 branch 2 times, most recently from ad85d41 to 335de89 Compare July 9, 2024 14:16
@trivikr
Copy link
Member Author

trivikr commented Jul 9, 2024

CI failure in build

src/S3Client.ts:311:58 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'S3ResolvedConfig'.
  Type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & UserAgentResolvedConfig' is missing the following properties from type 'S3ResolvedConfig': followRegionRedirects, s3ExpressIdentityProvider

311     this.middlewareStack.use(getValidateBucketNamePlugin(this.config));
                                                             ~~~~~~~~~~~

src/S3Client.ts:313:64 - error TS2345: Argument of type 'S3ClientResolvedConfig' is not assignable to parameter of type 'PreviouslyResolved'.
  Property 'followRegionRedirects' is missing in type 'SmithyResolvedConfiguration<HttpHandlerOptions> & Required<ClientDefaults> & RuntimeExtensionsConfig & ... 6 more ... & UserAgentResolvedConfig' but required in type 'PreviouslyResolved'.

313     this.middlewareStack.use(getRegionRedirectMiddlewarePlugin(this.config));
                                                                   ~~~~~~~~~~~

  ../../packages/middleware-sdk-s3/dist-types/region-redirect-middleware.d.ts:7:5
    7     followRegionRedirects: boolean;
          ~~~~~~~~~~~~~~~~~~~~~
    'followRegionRedirects' is declared here.

src/runtimeConfig.ts:48:15 - error TS2339: Property 'disableS3ExpressSessionAuth' does not exist on type 'S3ClientConfig'.

48       config?.disableS3ExpressSessionAuth ?? loadNodeConfig(NODE_DISABLE_S3_EXPRESS_SESSION_AUTH_OPTIONS),
                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~


Found 3 errors in 2 files.

Errors  Files
     2  src/S3Client.ts:311
     1  src/runtimeConfig.ts:48
error Command failed with exit code 2.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant