feat(amazonq): allow users to skip tests #5607
Open
+151
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Note: the backend work for this feature is not done yet, so we don't want to merge it yet. |
dhasani23
force-pushed
the
customBuildCommand
branch
from
0fc839a
to
0b5c066
Compare
dhasani23
commented
Sep 17, 2024
| } | ||
|
|
||
| // Explicitly set metric as failed since no exception was caught | ||
| telemetry.record({ result: MetadataResult.Fail, reason: errorReason }) |
There was a problem hiding this comment.
All of the above logic removed (same as below) was entirely just to form the errorReason string. We include all of that info in the IDE logs already, and we can simply put the error code in telemetry to simplify.
dhasani23
force-pushed
the
customBuildCommand
branch
from
0b5c066
to
ebc79cf
Compare
added 10 commits
September 19, 2024 10:42
dhasani23
force-pushed
the
customBuildCommand
branch
from
ebc79cf
to
bd64226
Compare
JuliaABurch
reviewed
Sep 19, 2024
| // one of these must be true | ||
| if (skipTestsSelection === CodeWhispererConstants.skipUnitTestsMessage) { | ||
| transformByQState.setCustomBuildCommand(CodeWhispererConstants.skipUnitTestsBuildCommand) | ||
| } else if (skipTestsSelection === CodeWhispererConstants.doNotSkipUnitTestsMessage) { |
There was a problem hiding this comment.
Is it worth just making this an else and not skipping unit tests by default? What happens if setCustomBuildCommand is never called?
There was a problem hiding this comment.
Yes, will fix. Our default should be to not skip tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Some users transform projects with long-running tests.
Solution
Allow users to skip tests by prompting them via chat and passing the relevant flag to skip tests through the
manifest.json.License: I confirm that my contribution is made under the terms of the Apache 2.0 license.