Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telemetry(dev): add tracking for empty path file scenario #5625

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tverney
Copy link
Contributor

@tverney tverney commented Sep 18, 2024

Problem

When customer use workspaces to generate files, RTS and LLM cannot decide which folder to deliver the generated file. We're for now tracking how many times we reach for accountability and prioritization.

Solution

Add telemetry to count and save the conversationIds that reach this specific workspace usage.

PS: This is should only be included in VS Code since the Workspaces capability its only used here.


License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required.

@tverney tverney marked this pull request as ready for review September 18, 2024 17:19
@tverney tverney requested a review from a team as a code owner September 18, 2024 17:19
@tverney tverney changed the title fix(amazonqFeatureDev): include telemetry for empty path file scenario fix(dev): include telemetry for empty path file scenario Sep 18, 2024
@@ -939,6 +939,20 @@
}
]
},
{
"name": "amazonq_wsOrphanedDocuments",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my other comment, can we move this to the common definition in https://github.com/aws/aws-toolkit-common

Copy link
Contributor Author

@tverney tverney Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good. I'll add there and then import here. Should I expect soon we remove then the generate part from vs code and just use from the common?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

@tverney tverney Sep 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jpinkney-aws should we merge common first or can I already include here those changes?

@justinmk3
Copy link
Contributor

When customer use workspaces to generate files, RTS and LLM cannot decide which folder to deliver the generated file. We're for now tracking how many times we reach for accountability and prioritization.

I don't understand what this means, nor the explanation in aws/aws-toolkit-common#856 .

Can this not be a field added to an existing metric instead of a new metric?

@tverney tverney changed the title fix(dev): include telemetry for empty path file scenario telemetry(dev): include telemetry for empty path file scenario Sep 18, 2024
@tverney tverney changed the title telemetry(dev): include telemetry for empty path file scenario telemetry(dev): add tracking for empty path file scenario Sep 18, 2024
@tverney
Copy link
Contributor Author

tverney commented Sep 18, 2024

When customer use workspaces to generate files, RTS and LLM cannot decide which folder to deliver the generated file. We're for now tracking how many times we reach for accountability and prioritization.

I don't understand what this means, nor the explanation in aws/aws-toolkit-common#856 .

Can this not be a field added to an existing metric instead of a new metric?

Well, @jpinkney-aws suggested adding a new generic metric because we currently don't have one for it. In essence, team wanna track a specific scenario that's reached in VS Code to understand the usage of it and proper prioritization by RTS.

@justinmk3
Copy link
Contributor

suggested adding a new generic metric because we currently don't have one

Ok. But amazonq_trackScenarioCountUsage is rather specific. Why does it mention "count" in the name? If we want to attach other fields (besides the "count") for that scenario, then we would need a new metric...

why not name it amazonq_trackScenario ? But also, every metric tracks a "scenario" already, so adding this metric which has a scenario field seems questionable.

@tverney
Copy link
Contributor Author

tverney commented Sep 18, 2024

When customer use workspaces to generate files, RTS and LLM cannot decide which folder to deliver the generated file. We're for now tracking how many times we reach for accountability and prioritization.

I don't understand what this means, nor the explanation in aws/aws-toolkit-common#856 .

Can this not be a field added to an existing metric instead of a new metric?

Well, the count its because we want limit the telemetry to just count the number of times we reach a specific condition. It was specific before, however, it was suggested to amplify to something more generic, so now it's talking about a "scenario". We will not be doing more than just counting for the moment. If you like it better, we could call it amazonq_trackConditionCountUsage. I'm ok with either naming conventions its good for you, the goal here its just have metrics on a "specific" condition for us.

@justinmk3
Copy link
Contributor

For reference: aws/aws-toolkit-common#856 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants