-
Notifications
You must be signed in to change notification settings - Fork 413
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
telemetry(dev): add tracking for empty path file scenario #5625
base: master
Are you sure you want to change the base?
Conversation
This pull request modifies code in src/ but no tests were added/updated. Confirm whether tests should be added or ensure the PR description explains why tests are not required. |
@@ -939,6 +939,20 @@ | |||
} | |||
] | |||
}, | |||
{ | |||
"name": "amazonq_wsOrphanedDocuments", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to my other comment, can we move this to the common definition in https://github.com/aws/aws-toolkit-common
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good. I'll add there and then import here. Should I expect soon we remove then the generate part from vs code and just use from the common?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jpinkney-aws should we merge common first or can I already include here those changes?
packages/amazonq/.changes/next-release/Bug Fix-0d324321-bddd-4f93-80c4-80978930f157.json
Show resolved
Hide resolved
I don't understand what this means, nor the explanation in aws/aws-toolkit-common#856 . Can this not be a field added to an existing metric instead of a new metric? |
Well, @jpinkney-aws suggested adding a new generic metric because we currently don't have one for it. In essence, team wanna track a specific scenario that's reached in VS Code to understand the usage of it and proper prioritization by RTS. |
Ok. But why not name it |
Well, the count its because we want limit the telemetry to just count the number of times we reach a specific condition. It was specific before, however, it was suggested to amplify to something more generic, so now it's talking about a "scenario". We will not be doing more than just counting for the moment. If you like it better, we could call it amazonq_trackConditionCountUsage. I'm ok with either naming conventions its good for you, the goal here its just have metrics on a "specific" condition for us. |
For reference: aws/aws-toolkit-common#856 (comment) |
Problem
When customer use workspaces to generate files, RTS and LLM cannot decide which folder to deliver the generated file. We're for now tracking how many times we reach for accountability and prioritization.
Solution
Add telemetry to count and save the conversationIds that reach this specific workspace usage.
PS: This is should only be included in VS Code since the Workspaces capability its only used here.
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.