feat(ec2): provide link for customer to view system logs #5633
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Limited ability to diagnose problems with EC2 instances provided in the toolkit.
Solution
Add a right click option to provide system log of Ec2 instance in read-only file view.
Implementation Details
decodeBase64
incore/src/shared/utilities/textUtilities.ts
andUriSchema
incore/src/shared/utilities/uriUtils.ts
.decodeBase64
is a helper function to wrap the use ofBuffer.from(X, "base64").toString()
throughout the toolkit.UriSchema
provides a general framework for translating between an object and an URI, and vice versa. It allows us to avoid writing theisValid
method in all cases. With more work this could likely be more general, but is only used twice so unclear if it is worth pursuing.Pictures
License: I confirm that my contribution is made under the terms of the Apache 2.0 license.