Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ec2): provide link for customer to view system logs #5633

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Hweinstock
Copy link
Contributor

@Hweinstock Hweinstock commented Sep 19, 2024

Problem

Limited ability to diagnose problems with EC2 instances provided in the toolkit.

Solution

Add a right click option to provide system log of Ec2 instance in read-only file view.

Implementation Details

  • Log view does NOT live update. This would require refactoring the CWL significantly. Better to get the feature out and see if this is something customers want/need.
  • To reduce code duplication two new utility components were added decodeBase64 incore/src/shared/utilities/textUtilities.ts and UriSchema in core/src/shared/utilities/uriUtils.ts.
  • decodeBase64 is a helper function to wrap the use of Buffer.from(X, "base64").toString() throughout the toolkit.
  • UriSchema provides a general framework for translating between an object and an URI, and vice versa. It allows us to avoid writing the isValid method in all cases. With more work this could likely be more general, but is only used twice so unclear if it is worth pursuing.
  • These changes involved changing some function calls, especially in the CWL code, but does not impact functionality.

Pictures

image image

License: I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link

This pull request implements a feature or fix, so it must include a changelog entry. See CONTRIBUTING.md#changelog for instructions.

@Hweinstock Hweinstock changed the title feat(ec2): provide link for customer to view system logs (WIP)feat(ec2): provide link for customer to view system logs Sep 19, 2024
@Hweinstock Hweinstock changed the title (WIP)feat(ec2): provide link for customer to view system logs feat(ec2): provide link for customer to view system logs Sep 19, 2024
@Hweinstock Hweinstock marked this pull request as ready for review September 19, 2024 18:36
@Hweinstock Hweinstock requested a review from a team as a code owner September 19, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant