Fix build on macOS 10.15 and earlier #4674
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The team has discussed this PR and concluded that s2n-tls won't be able to support MacOS versions that Apple does not support. MacOS Catalina has been unsupported by Apple since 2022. We have no mechanism to reproduce your problem or test this fix, and couldn't guarantee that s2n-tls would continue to work with Catalina in the future even if we fixed this issue. With that in mind, redefining "__DARWIN_ALIGN32" based on MacOS version is a fairly specific and complex solution to this problem and not one I'm comfortable merging, especially not without automated testing. I did see this, however. Would switching from "= { 0 }" to memset for initialization fix your problem? That would essentially be a no-op change, and not Catalina-specific. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
Resolves #4673
Description of changes:
Currently the build is broken on every macOS from Catalina down, both with gcc and clang.
This fixes it.
Verified on 10.6, but we know it works on other systems too.