Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add more generic analyzer buildspec #4747

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

boquan-fang
Copy link
Contributor

@boquan-fang boquan-fang commented Sep 3, 2024

Resolved issues:

This PR makes a more generic buildspec_analyzer job. This job will contain both

  • valgrind unit tests
  • sanitizer (ASAN, UBSAN) unit tests

After this PR is merged, I will follow up with another PR adding the valgrind jobs.

This work is part of the effort to deprecate the make Valgrind tests and switch to running them through CMake.

Description of changes:

  • add path to deep inspection as buildspec
  • separate sanitizers build from deep inspection
  • add _sanitizers suffix to every build's identifiers

Call-outs:

  • Add CTest memcheck in the next PR.

Testing:

  • I have manually ran CI AddressSanitizer check for this PR.
  • I checked the runtime of build for AddressSanitizer and there is no performance regression.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Boquan Fang added 2 commits September 3, 2024 16:56
* add path to deep inspection as buildspec
* separate sanitizers build from deep inspection
@github-actions github-actions bot added the s2n-core team label Sep 3, 2024
@boquan-fang boquan-fang marked this pull request as ready for review September 3, 2024 18:05
* change the filename of `buildspec_deep_inspection.yml` to
  `buildspec_analyzers.yml`
@boquan-fang boquan-fang changed the title refactor: change asan to deep insepction refactor: add more generic analyzer buildspec Sep 4, 2024
* remove hardcoded path for internal release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants