-
Notifications
You must be signed in to change notification settings - Fork 704
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: add more generic analyzer buildspec #4747
Open
boquan-fang
wants to merge
5
commits into
aws:main
Choose a base branch
from
boquan-fang:dont-mlock-fix
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add path to deep inspection as buildspec * separate sanitizers build from deep inspection
* change the filename of `buildspec_deep_inspection.yml` to `buildspec_analyzers.yml`
jmayclin
reviewed
Sep 4, 2024
boquan-fang
changed the title
refactor: change asan to deep insepction
refactor: add more generic analyzer buildspec
Sep 4, 2024
jmayclin
reviewed
Sep 4, 2024
lrstewart
reviewed
Sep 4, 2024
dougch
reviewed
Sep 4, 2024
* remove hardcoded path for internal release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
This PR makes a more generic buildspec_analyzer job. This job will contain both
After this PR is merged, I will follow up with another PR adding the valgrind jobs.
This work is part of the effort to deprecate the make Valgrind tests and switch to running them through CMake.
Description of changes:
_sanitizers
suffix to every build's identifiersCall-outs:
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.