Al2023 codebuild #4756
Open
Al2023 codebuild #4756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goatgoose
approved these changes
Sep 12, 2024
Co-authored-by: Sam Clark <[email protected]>
lrstewart
approved these changes
Sep 17, 2024
Comment on lines
+37
to
40
| if [[ "$OS_NAME" == "linux" && -z "$CODEBUILD_BUILD_ARN_" ]]; then | ||
| PRLIMIT_LOCATION=$(which prlimit) | ||
| sudo -E ${PRLIMIT_LOCATION} --pid "$$" --memlock=unlimited:unlimited; | ||
| fi |
There was a problem hiding this comment.
Probably out of scope, but is this even necessary? The unit tests automatically disable mlock, which is what the memlock limit would be about.
There was a problem hiding this comment.
historical carry-over, maybe we need an issue to verify the S2N_DONT_MLOCK and clean this up
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved issues:
partial for #4681
Description of changes:
CodeBuild scripts and buildspec changes to add AL2023.
Call-outs:
I've renamed the amazon linux related files to not contain a version numbeer.
Testing:
How is this change tested (unit tests, fuzz tests, etc.)? local docker images, CI and a manual run
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.