-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add SFN driven rosbag-image-pipeline
module
#403
feat: Add SFN driven rosbag-image-pipeline
module
#403
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wondering if we should make this a generic module...keep it in ADDF, but it may be better to make all new modules generic so it can be leveraged in other projects?
Lets debate
Depends how generic you mean.. A good 90% of this code is setting up what was in the DAG. So if you mean bringing your own logic for EMR, batch, sagemaker, yes. For just SFN usage, doesn't quite make sense. |
This comment was marked as resolved.
This comment was marked as resolved.
Changes Addressed, requesting re-review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need to address the accountID being committed....the other comments are nice to have
seed-farmer
integration testingBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.