Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI on all changed modules, not just the first one. #571

Merged
merged 8 commits into from
Aug 15, 2024

Conversation

clokep
Copy link
Collaborator

@clokep clokep commented Aug 15, 2024

Issue #, if available: N/A, regressed in #568, port of awslabs/idf-modules#281

Description of changes: Ensure tests for all changed modules run, not just the first one.

$ALL_CHANGED_FILES contains a space-separated list of changed files, when piped into cut this resulted in only returning the results of the first changed file.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

.python-version Outdated Show resolved Hide resolved
@clokep
Copy link
Collaborator Author

clokep commented Aug 15, 2024

Check out https://github.com/awslabs/autonomous-driving-data-framework/actions/runs/10408983026/job/28827749779?pr=571 for a passing run of all modules unit tests/lint.

@clokep clokep marked this pull request as ready for review August 15, 2024 19:09
@malachi-constant malachi-constant requested a review from a team August 15, 2024 19:10
@malachi-constant malachi-constant merged commit b8b9c93 into awslabs:main Aug 15, 2024
4 checks passed
@clokep clokep deleted the test-all-modules branch August 15, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants