chore: Make jupyter-hub module generic and update deps
#585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
malachi-constant
added
bug
malachi-constant
requested review from
srinivasreddych,
clokep,
dgraeber,
kukushking and
LeonLuttenberger
LeonLuttenberger
approved these changes
Sep 4, 2024
| @@ -20,12 +21,12 @@ deploy: | |||
| - docker push $REPOSITORY_URI:latest && docker push $REPOSITORY_URI:$IMAGE_TAG | |||
| - cd .. | |||
| - cdk deploy --require-approval never --progress events --app "python app.py" --outputs-file ./cdk-exports.json | |||
| - export ADDF_MODULE_METADATA=$(python -c "import json; file=open('cdk-exports.json'); print(json.load(file)['addf-${ADDF_DEPLOYMENT_NAME}-${ADDF_MODULE_NAME}']['metadata'])") | |||
| - export SEEDFARMER_MODULE_METADATA=$(python -c "import json; file=open('cdk-exports.json'); print(json.load(file)['addf-${SEEDFARMER_DEPLOYMENT_NAME}-${SEEDFARMER_MODULE_NAME}']['metadata'])") | |||
There was a problem hiding this comment.
Sorry for the late review.
addf needs to be replaced with SEEDFARMER_PROJECT name here
(OR)
you could run seedfarmer metadata convert -f cdk-exports.json || true command to grab the metadata and avoid running this one liner python command
There was a problem hiding this comment.
Will resolve in a new PR, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #583
Description of changes:
jupyter-hubmodule genericBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.