more comments and format clean up

awslabs · Sep 11, 2024 · bd58da0 · bd58da0
1 parent 287094f
commit bd58da0
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 5 deletions.
diff --git a/include/aws/io/event_loop.h b/include/aws/io/event_loop.h
@@ -146,8 +146,8 @@ struct aws_event_loop_group {
     struct aws_shutdown_callback_options shutdown_options;
 };
 
-typedef struct aws_event_loop *(
-    aws_new_system_event_loop_fn)(struct aws_allocator *alloc, const struct aws_event_loop_options *options);
+typedef struct aws_event_loop *(aws_new_system_event_loop_fn)(struct aws_allocator *alloc,
+                                                              const struct aws_event_loop_options *options);
 
 struct aws_event_loop_configuration {
     enum aws_event_loop_style style;

diff --git a/include/aws/io/io.h b/include/aws/io/io.h
@@ -28,10 +28,10 @@ struct aws_io_handle {
         void *handle;
     } data;
     void *additional_data;
-    #if AWS_USE_DISPATCH_QUEUE
+#if AWS_USE_DISPATCH_QUEUE
     aws_io_set_queue_on_handle_fn *set_queue;
     aws_io_clear_queue_on_handle_fn *clear_queue;
-    #endif /* AWS_USE_DISPATCH_QUEUE */
+#endif /* AWS_USE_DISPATCH_QUEUE */
 };
 
 enum aws_io_message_type {

diff --git a/source/darwin/dispatch_queue_event_loop.c b/source/darwin/dispatch_queue_event_loop.c
@@ -467,6 +467,10 @@ static int s_unsubscribe_from_io_events(struct aws_event_loop *event_loop, struc
     return AWS_OP_SUCCESS;
 }
 
+// The dispatch queue will assign the task block to threads, we will threat all
+// tasks as cross thread tasks. Ignore the caller thread verification for apple
+// dispatch queue.
 static bool s_is_on_callers_thread(struct aws_event_loop *event_loop) {
+    (void)event_loop;
     return true;
-}
+}