only try to generate coverage on success

awslabs · Oct 10, 2023 · ce775ed · ce775ed
1 parent a56e486
commit ce775ed
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/builder/actions/cmake.py b/builder/actions/cmake.py
@@ -246,9 +246,13 @@ def run(self, env):
             return
 
         ctest = toolchain.ctest_binary()
-        sh.exec(*toolchain.shell_env, ctest,
-                "--output-on-failure", working_dir=project_build_dir, check=True)
-        # Try to generate the coverage report. Will be ignored by ctest if no coverage data available.
+        try:
+            sh.exec(*toolchain.shell_env, ctest,
+                    "--output-on-failure", working_dir=project_build_dir, check=True)
+        except:
+            # Skip generate the coverage report on error
+            return
+        # If CTest found no test, generate coverage will hang
         sh.exec(*toolchain.shell_env, ctest,
                 "-T", "coverage", working_dir=project_build_dir, check=True)