Skip to content

Commit

Permalink
fix: Custom endpoint config field (#1044)
Browse files Browse the repository at this point in the history
  • Loading branch information
jbelkins committed Jun 21, 2023
1 parent 06bb577 commit 4702133
Show file tree
Hide file tree
Showing 2 changed files with 41 additions and 0 deletions.
1 change: 1 addition & 0 deletions Sources/Core/AWSClientRuntime/AWSClientConfiguration.swift
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ public class AWSClientConfiguration<ServiceSpecificConfiguration: AWSServiceSpec
DefaultSDKRuntimeConfiguration<DefaultRetryStrategy, DefaultRetryErrorInfoProvider>

self.credentialsProvider = credentialsProvider
self.endpoint = endpoint
self.serviceSpecific = try serviceSpecific ?? ServiceSpecificConfiguration(endpointResolver: nil)
self.frameworkMetadata = frameworkMetadata
self.region = region
Expand Down
40 changes: 40 additions & 0 deletions Tests/Core/AWSClientRuntimeTests/AWSClientConfigurationTests.swift
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
//
// Copyright Amazon.com Inc. or its affiliates.
// All Rights Reserved.
//
// SPDX-License-Identifier: Apache-2.0
//

import Foundation
import XCTest
import AWSClientRuntime

class AWSClientConfigurationTests: XCTestCase {

func test_region_regionPropertyGetsSet() throws {
let region = "us-east-1"
let subject = try AWSClientConfiguration<TestAWSServiceSpecificConfiguration>(region: region)
XCTAssertEqual(subject.region, region)
}

func test_endpoint_endpointPropertyGetsSet() throws {
let endpoint = "https://my-xctest-endpoint.test.com/"
let subject = try AWSClientConfiguration<TestAWSServiceSpecificConfiguration>(region: "us-east-1", endpoint: endpoint)
XCTAssertEqual(subject.endpoint, endpoint)
}
}

struct TestAWSServiceSpecificConfiguration: AWSServiceSpecificConfiguration {
struct EndpointResolver {}

typealias AWSServiceEndpointResolver = EndpointResolver

var endpointResolver: EndpointResolver

init(endpointResolver: EndpointResolver?) throws {
self.endpointResolver = endpointResolver ?? EndpointResolver()
}

var serviceName: String { "TestAWSService" }
var clientName: String { "TestAWSServiceClient" }
}

0 comments on commit 4702133

Please sign in to comment.