Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enable all services #1048

Merged
merged 4 commits into from
Jun 22, 2023
Merged

chore: Enable all services #1048

merged 4 commits into from
Jun 22, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Jun 21, 2023

Issue #

#1047

Description of changes

Re-enables code generation of all AWS services.

(also: disables the Swiftlint trailing_comma rule)

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins added the blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. label Jun 21, 2023
@jbelkins
Copy link
Contributor Author

This is currently blocked and should not merge until smithy-lang/smithy-swift#566 has merged.

@jbelkins jbelkins requested a review from waahm7 June 21, 2023 20:13
@jbelkins jbelkins self-assigned this Jun 21, 2023
@jbelkins jbelkins added this to the GA milestone Jun 21, 2023
@jbelkins
Copy link
Contributor Author

smithy-lang/smithy-swift#566 has merged, so this is no longer blocked.

@jbelkins jbelkins removed the blocked Work is blocked on this issue for this codebase. Other labels or comments may indicate why. label Jun 22, 2023
@jbelkins jbelkins removed this from the GA milestone Jun 22, 2023
@jbelkins jbelkins merged commit 53cd1db into main Jun 22, 2023
7 checks passed
@jbelkins jbelkins deleted the jbe/enable_all_aws_services branch June 22, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants