fix: Make AWS SDK CLI test runner fail when tests fail #1049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbelkins
commented
Jun 21, 2023
|
Ran this Model Integration CI job on this branch: As expected, it now fails the CI job when tests fail. Reverting |
waahm7
approved these changes
Jun 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
#1046
Description of changes
Currently, when the AWS SDK CLI test runner fails (i.e.
swift testexits with a nonzero status code), the AWS SDK CLI command exits but with a status code zero for success.With this change, when the AWS SDK CLI runs a
Processand the process exits with a nonzero exit code, anExitCodeerror (defined in the Swift Argument Parser package) is thrown with the abnormal exit code.A test is added to verify the change works as expected.
New/existing dependencies impact assessment, if applicable
No new dependencies were added to this change.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.