Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add concurrent integration test & utils #1596

Merged
merged 27 commits into from
Sep 23, 2024
Merged

Conversation

sichanyoo
Copy link
Contributor

@sichanyoo sichanyoo commented Jun 27, 2024

Issue #

#1561

Description of changes

  • Adds utility functions (one that takes in variadic args and one that doesn't) that concurrently runs a passed-in function count number of times, idea taken from draft PR: feat: Add concurrent integration tests #1484
  • Adds integration test for S3 that puts & gets 1MB files and runs them 100 times concurrently

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest of this is fine, but let's not commit 100MB of garbage to the project. Try generating that data in a temp dir, then using that in the test.

@sichanyoo sichanyoo requested a review from jbelkins July 9, 2024 18:39
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See individual comments

@sichanyoo sichanyoo changed the title feat: Add concurrent integration tests feat: Add concurrent integration test & utils Sep 18, 2024
Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question

Copy link
Contributor

@jbelkins jbelkins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests still seem to take quite a while (10 sec per test on Linux+CRT, 30 per sec on Mac+URLSession) but I'm approving because the tests do what they are supposed to do.

If we want to adjust the number of concurrent runs or the test duration, we can do that at a later time.

@sichanyoo sichanyoo merged commit fc8e819 into main Sep 23, 2024
29 checks passed
@sichanyoo sichanyoo deleted the feat/concurrent-tests branch September 23, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants