Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use aarch64 runner for Flatpak #1149

Merged
merged 5 commits into from
Feb 22, 2024

Conversation

darkdragon-001
Copy link
Collaborator

@darkdragon-001 darkdragon-001 commented Jan 23, 2024

This brings down the arm64 Flatpak build time from ~180min to ~20min.

@darkdragon-001 darkdragon-001 changed the base branch from main to axolotl_presage January 23, 2024 20:28
@darkdragon-001 darkdragon-001 force-pushed the test-aarch64-runner branch 7 times, most recently from f6405b8 to 9a542e7 Compare January 23, 2024 23:15
@nanu-c nanu-c changed the base branch from axolotl_presage to main January 31, 2024 22:59
@darkdragon-001 darkdragon-001 changed the title Test aarch64 runner Use aarch64 runner for Flatpak Feb 14, 2024
@darkdragon-001 darkdragon-001 force-pushed the test-aarch64-runner branch 5 times, most recently from 0ae2efb to 61a4328 Compare February 18, 2024 20:44
@darkdragon-001
Copy link
Collaborator Author

@barthalion Do you have an idea why the arm64 build fails with Error: Failed to update org.gnome.Sdk: Invalid cross-device link?

@barthalion
Copy link

This would typically mean something is trying to hardlink across devices. Not sure how much sense this makes in the context of GitHub Actions.

@barthalion
Copy link

barthalion commented Feb 19, 2024

Anyway, it seems to have failed with some segfault, probably unrelated to that message.

@darkdragon-001
Copy link
Collaborator Author

The arm64 build now seems to work with the image from flathub-infra 😄

@darkdragon-001 darkdragon-001 marked this pull request as ready for review February 21, 2024 23:54
nanu-c
nanu-c previously approved these changes Feb 22, 2024
Comment on lines 386 to 387
# BUG https://github.com/flatpak/flatpak-github-actions/pull/179
# image: bilelmoussaoui/flatpak-github-actions:gnome-45
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this still true?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer the image from flatpak instead of flathub-infra as it is more general and smaller and we are also using the action from that repository but the maintainer is not very responsive at the moment. So I suggest keeping the comment for future reference.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ ❱ docker images | grep gnome-45
ghcr.io/flathub-infra/flatpak-github-actions   gnome-45   0cd259c4f7c9   26 hours ago   5.45GB
bilelmoussaoui/flatpak-github-actions          gnome-45   e84de63f2fa2   4 days ago     7.55GB

It's actually bigger by 2 GB.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting, I thought it was the other way round as this was based on the small fedora image. But it looks like it has a lot of inefficiencies like installing Flatpak builder twice (dnf and flatpak) for example.

@barthalion Which GitHub actions and Docker images do you recommend people to use? It is a little bit confusing with the many GitHub organizations and forks...

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The image and action from the flathub-infra org is the one we as in Flathub going to be recommending for the foreseable future.

Copy link
Collaborator Author

@darkdragon-001 darkdragon-001 Feb 22, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@barthalion thanks. Are you just using @master for the version of the GitHub Action? Or pin a commit SHA and update with dependabot?

@nanu-c nanu-c merged commit f4e4fdf into axolotl-chat:main Feb 22, 2024
14 checks passed
@darkdragon-001 darkdragon-001 deleted the test-aarch64-runner branch February 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants