Axolotl presage #985

nanu-c · 2023-01-21T21:34:01Z

This pr replaces the go backend, crayfish, textsecure and crayfish with presage, libsignal-service-rs and libsignal.

The new backend is written in rust instead of go in order to the upstream library from signal and share efforts with whisperfish from sailfishos, flare as gtk app, and gurk-rs a terminal client. The work in progress only supports linking as secondary device for now and after a successful linking axolotl has to be restarted.

There are 2 features for now:

tauri, tauri is a replacment for electron
ut, this is the system integration for ubuntu touch

Development

install rust
install npm
get dependencies for axolotl web cd axolotl-web && npm i
for tauri:
- cargo run --features tauri
- or cargo tauri dev --features tauri (this commands enables hot reloading of everything)
for ubuntu touch
- cargo run --features ut
- or: clickable build --libs axolotlweb && clickable desktop
native development without tauri or ut
- run axolotl as deamon cargo run -- -d
- run axolotl-web cd axolotl-web && npm run dev

A lot of things have to be done

In libsignal-service-rs (means broken in all projects)

contact discovery

In presage

save only necessary messages to store
group handling
add contact on incoming message from unknown sender

Axolotl

Axolotl packaging

ubuntu touch click
flatpak
deb package
snap

We can also add testing

unit test for axolotl-web
test for the rust backend
add cypress e2e tests

Flaburgan · 2023-01-21T22:19:40Z

Wow! This is huge, and a very big step in the good direction! Thank you for all the hard work!

Blackoverflow

Sorry, I couldn't help myself to start reviewing.

I will review further, when you request it.

axolotl-web/package.json

Blackoverflow · 2023-01-22T20:57:23Z

axolotl-web/src/pages/ChatList.vue

@@ -23,26 +23,26 @@
      <div v-for="chat in chatList" :key="chat.id" class="row">
        <!-- chat entry -->
        <div
-          :id="chat.ID"


Changes like these happen, because there is no defined model for objects send to the frontend.
I want to suggest, that it may help to decouple the object models for communication with the frontend (DTO's) from the backend logic. This would introduce a mapping between backend objects and DTO's, but I think its worth it. What's your take on that?

Do you have an example for how this could be done? The changes here are happening because in rust a variable shouldn't start with an uppercase letter.

Blackoverflow · 2023-01-22T20:59:44Z

axolotl-web/src/pages/ChatList.vue

                  alt="Avatar image"
                  @error="onImageError($event)"
                />
-                {{ chat.ID[0] }}
+                {{ `${chat.title[0]}${chat.title[1]?chat.title[1]:""}` }}


I would like to introduce a function for this logic. I'm not a fan of logic within the template.

Blackoverflow · 2023-01-22T21:02:45Z

axolotl-web/src/pages/Contacts.vue

@@ -43,11 +43,11 @@
                  alt="Avatar image"
                  @error="onImageError($event)"
                />
-                {{ c.Name[0] ? c.Name[0] + c.Name[1] : c.Name[0] }}
+                {{ c.name[0] ? c.name[0] + c.name[1] : c.name[0] }}


This line still contains a bug. Correct would be:
{{ c.name[1] ? c.name[0] + c.name[1] : c.name[0] }}

Also: I would like to introduce a function for this logic. I'm not a fan of logic within the template.

Blackoverflow · 2023-01-22T21:04:00Z

axolotl-web/src/pages/Contacts.vue

@@ -76,12 +76,12 @@
                alt="Avatar image"
                @error="onImageError($event)"
              />
-              {{ c.Name[0] ? c.Name[0] + c.Name[1] : c.Name[0] }}
+              {{ c.name[0] ? c.name[0] + c.name[1] : c.name[0] }}


I'm even less happy about copied (wrong) logic within the template.

Blackoverflow · 2023-01-22T21:09:43Z

axolotl-web/src/pages/Contacts.vue

+  /*
+.avatar{
+  border-radius: 50px;
+background-color: #2090ea;
+width: 50px;
+height: 50px;
+justify-content: center;
+align-items: center;
+display: flex;
+color: #FFF;
+margin:20px;
+} */


Remove it or use it.

Blackoverflow · 2023-01-22T21:11:36Z

axolotl-web/src/components/Message.vue

-      "
-      class="avatar"
-    >
+  <div :key="message.ID" :class="{


message.ID vs chat.id can we make this consistent?

The message has no field ID anymore, this is still a clean up in progress

Blackoverflow · 2023-01-22T21:17:16Z

axolotl-web/src/components/Message.vue

+  <div :key="message.ID" :class="{
+    'col-12': true,
+    'message-container': true,
+    outgoing: message.is_outgoing,
+    sent: message.IsSent && message.is_outgoing,
+    read: message.IsRead && message.is_outgoing,
+    delivered: message.Receipt && message.is_outgoing,
+    incoming: !message.is_outgoing,
+    status:
+      (message.Flags > 0 &&
+        message.Flags !== 11 &&
+        message.Flags !== 13 &&
+        message.Flags !== 14) ||
+      message.StatusMessage ||
+      (message.Attachment &&
+        message.Attachment.includes('null') &&
+        message.Message === ''),
+    hidden: message.Flags === 18,
+    error: message.timestamp === 0 || message.SendingError,
+    'group-message':
+      isGroup && (message.Flags === 0 || message.Flags === 12 || message.Flags === 13),
+  }">


There is a lot of logic here for setting the right css classes. Is there a cleaner way to make this?
And can we move the logic into funktions, if its more than one logic operation?

Same for here, the Flags field doesn't exist anymore but we have to add something like this again.

And i agree to move it into functions

Blackoverflow · 2023-01-22T21:18:48Z

axolotl-web/src/components/Message.vue

+      isGroup &&
+      (message.Flags === 0 || message.Flags === 12 || message.Flags === 13)


This logic is copied within 5 lines of code.

Blackoverflow · 2023-01-22T21:20:09Z

axolotl-web/src/pages/MessageList.vue

@@ -93,7 +93,7 @@
              @long-press="paste"
            />
          </div>
-          <div v-if="messageInput !== ''" class="messageInput-btn-container">
+          <div v-if="messageInput !== '' || true" class="messageInput-btn-container">


Remove this, as soon as its not needed anymore

Add the ability to send text messages

nanu-c · 2023-01-26T20:07:40Z

@Blackoverflow thank you for your review!

dvn0 · 2023-11-12T13:44:06Z

Actually the ci always builds it at the moment. Don't know which checkout you have -> https://github.com/nanu-c/axolotl/actions/runs/6836277934/job/18591020900?pr=985#step:9:799

Yes, I noticed that it was working in CI and I've copied the steps there as closely as possible. I've tried several checkouts of this branch. Last commit I tried was d30193b

dvn0 · 2023-11-12T14:02:21Z

I figured it out. I was not copying the axolotl-web/dist/ dir to the correct path. Apologies for the noise!

WIP: Avoid npm nodejs version conflict in Clickable images

nanu-c · 2023-11-18T19:46:11Z

I figured it out. I was not copying the axolotl-web/dist/ dir to the correct path. Apologies for the noise!

No problem! It's still a lot to do.

TriVoxel · 2023-12-06T09:17:56Z

Hey guys, glad to see you chippin' away at this! Progress is looking good. I'm stoked! Keep at it, you got something awesome here, I can tell!!

torfmaster · 2023-12-09T19:36:33Z

Hi dear axolotl team,

first of all thank you for creating axolotl and (more importantly) maintaining it. I have been using it for almost two years now (dispite the frequent changes on the Signal server side).

I have a uncommon proposal, but let me explain:

My impression is that axolotl has become (at least for me) a "single point of failure" for the whole idea of using an operating system on a mobile phone which is neither Android nor iOS. That is: Axolotl is the only available Signal client for free and open source operating systems. However, there is currently no version that is compatible with the Signal servers so the only option is to use Signal Desktop on a Laptop.
My proposal is: merge this PR as soon as it produces usable artifacts and make the remaining tasks (and the remaining artifacts) issues to be solved independently. This makes progress more visible (I actually only accidentally stumbled over this PR) and also implements some "divide and conquer" strategy for the remaining to dos.

I could myself offer the following during my Christmas Holidays (on this branch or on "main")

testing on Ubuntu Touch
some knowledge about Rust (including cross-compilation, warp)
experience in web development (though mostly react+typescript)

Let me know if (and how) I can support!

Remove conflicting yarn.lock

Fix Flatpak build

yorambh · 2024-01-31T10:03:38Z

axolotl-web/src/config.js

Any idea why the registration is broken ? I know thhat the server return 422 and I don't mind debugging, but if anyone has knowledge that saves time, it will be appreciated. thanks

nanu-c added 2 commits January 21, 2023 13:37

remove the old go backend

bcdf3ed

add rust backend with desktop linking

e0ca075

JamiKettunen mentioned this pull request Jan 22, 2023

Axolotl (Signal) app is not working HelloVolla/ubuntu-touch-beta-tests#159

Closed

Blackoverflow reviewed Jan 22, 2023

View reviewed changes

make websocket handler more failsafe

b9d47a0

nanu-c force-pushed the axolotl_presage branch from 9151992 to b9d47a0 Compare January 23, 2023 00:18

nanu-c and others added 10 commits January 23, 2023 08:11

fix route

9778037

fix mutex for message lists and fix showing the chat list

c74a022

update presage commit

9472ae9

Add the ability to send text messages

9777efb

Merge pull request #988 from nalysius/send-message

af79e89

Add the ability to send text messages

add notifications and hide non data messages

5df5a19

add notifications and hide non data messages

4c50bbd

hide empty messages

dbeec75

Add group fixes from presage

535fdf5

Show reactions

f277b4b

nanu-c added 12 commits January 26, 2023 21:17

update axolotl web dependencies

302bfa0

use yarn for building and fix main scrolling

a5ad672

put message handlers in proper functions

ecfe194

fix message ownership

2e4a574

add support for sending messages to groups

960b7df

update message list on receiving/sending

7c71514

Don't add uuid to sent message

2da6abc

break on receiving channel has ended

4538a78

add dbus to ut feature

149a495

Add notifications for ubuntu touch

9dfd929

improve message display

4175242

Add regsister button to axolotl web

7b0564a

nanu-c and others added 3 commits November 11, 2023 23:57

ci: clickable don't build axolotl-web

d30193b

Avoid npm nodejs version conflict in Clickable images

7177346

Put axolotlweb where Clickable expects it

ec707f7

jonnius and others added 2 commits November 16, 2023 08:07

Add workaround for Clickable bug

4c90349

Merge pull request #1119 from jonnius/node-local

31eac94

WIP: Avoid npm nodejs version conflict in Clickable images

nanu-c and others added 17 commits December 28, 2023 00:14

fix: threadmetadata panics and update presage to fix register

bcae9a7

fix: axolotl-web white screen and disable primary registration

e21309c

Ignore VSCode Devcontainer config folder

224ba69

Fix Rust formatting issues

1a1625c

Enable Dependabot for Cargo

1d72e05

Fix duplicate version in Cargo.lock

3f7e922

Fix package-lock.json

253a0ca

Remove conflicting yarn.lock

Remove obsolete references to golang files and Qt version

fe1fe67

Refactor Flatpak build

5daf132

Merge pull request #1146 from darkdragon-001/flatpak

48dc80a

Fix Flatpak build

update axolotl web dependencies

b56acf6

update dependencies and use libsignal-service via presage

33ab28f

fix: linter errors

cd64c2e

fix: clippy errros

666b94b

fix: ci: add protoc to clippy check

2807a70

fix: Add protoc to more build steps

8300e28

ci: move flatpack build to packaging

61360aa

yorambh reviewed Jan 31, 2024

View reviewed changes

nanu-c merged commit 99d28e3 into main Jan 31, 2024
10 of 13 checks passed

nanu-c deleted the axolotl_presage branch August 6, 2024 09:36

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Axolotl presage #985

Axolotl presage #985

nanu-c commented Jan 21, 2023 •

edited

Loading

Flaburgan commented Jan 21, 2023

Blackoverflow left a comment

Blackoverflow Jan 22, 2023

nanu-c Jan 26, 2023

Blackoverflow Jan 22, 2023

Blackoverflow Jan 22, 2023

Blackoverflow Jan 22, 2023

Blackoverflow Jan 22, 2023

Blackoverflow Jan 22, 2023

nanu-c Jan 26, 2023

Blackoverflow Jan 22, 2023

nanu-c Jan 26, 2023

nanu-c Jan 26, 2023

Blackoverflow Jan 22, 2023

Blackoverflow Jan 22, 2023

nanu-c commented Jan 26, 2023

dvn0 commented Nov 12, 2023

dvn0 commented Nov 12, 2023

nanu-c commented Nov 18, 2023

TriVoxel commented Dec 6, 2023

torfmaster commented Dec 9, 2023

yorambh Jan 31, 2024

		isGroup &&
		(message.Flags === 0 \|\| message.Flags === 12 \|\| message.Flags === 13)

Axolotl presage #985

Axolotl presage #985

Conversation

nanu-c commented Jan 21, 2023 • edited Loading

Flaburgan commented Jan 21, 2023

Blackoverflow left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nanu-c commented Jan 26, 2023

dvn0 commented Nov 12, 2023

dvn0 commented Nov 12, 2023

nanu-c commented Nov 18, 2023

TriVoxel commented Dec 6, 2023

torfmaster commented Dec 9, 2023

Choose a reason for hiding this comment

nanu-c commented Jan 21, 2023 •

edited

Loading