Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme and repo templates #1041

Merged
merged 2 commits into from
Sep 16, 2024
Merged

Update readme and repo templates #1041

merged 2 commits into from
Sep 16, 2024

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 10, 2024

Please Read the CONTRIBUTING Guidelines
In particular the portion on Commit Message Formatting

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

  • Docs update

Other information: Also updated the issue and PR templates.

@@ -6,7 +6,7 @@

<div align="center">
<a href="https://github.com/babel/babel">
<img src="https://rawgit.com/babel/logo/master/babel.svg" alt="Babel logo" width="200" height="200">
<img src="https://raw.githubusercontent.com/babel/logo/master/babel.svg" alt="Babel logo" width="200" height="200">
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rawgit has reached eol in 2018. I am surprised that it still works in 2024. Anyway we can just serve the logo from the GitHub CDN.

],
plugins: ['@babel/plugin-proposal-class-properties']
plugins: ['@babel/plugin-proposal-decorators', { version: "2023-11" }]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example configs are updated per the latest best practice.

@nicolo-ribaudo nicolo-ribaudo merged commit f765949 into main Sep 16, 2024
16 checks passed
@nicolo-ribaudo nicolo-ribaudo deleted the update-readme branch September 16, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants