Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Allow default assumptions #2701

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

liuxingbaoyu
Copy link
Member

No description provided.

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for babel ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 87f1e31
🔍 Latest deploy log https://app.netlify.com/sites/babel/deploys/636cda0e09040b0008885842
😎 Deploy Preview https://deploy-preview-2701--babel.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally I don't like the idea of intermediate checkbox, aka tri-state checkbox. The noNewArrows assumption is the only one that is enabled by default and we planned to disable it in Babel 8, to align with other assumptions.

I suggest we render the current default setting on UI, i.e. noNewArrows is true while the others are false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants