-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMake fixes #29
base: backtrace
Are you sure you want to change the base?
CMake fixes #29
Conversation
Thank you for your PR! I'm out until 23.01, expect further response then. |
ping |
I think we can't accept those changes as they are. Do they pose a problem for your build? |
Yes - without those |
Oh, now that I'm not on mobile I see the failed CI jobs. That's ok, the first commit ("Drop superfluous language from CMakeLists") is only a minor optimisation that works on my platform due to linking with system zlib, while in other cases you probably build your own copy? I can drop that, the only fix required is the other commit. |
Yeah, that'll do, but I need to figure out how to add Ninja to the runner - I'm having a fun time ;) https://github.com/backtrace-labs/crashpad/actions/workflows/main.yml |
This fixes compatibility with CMake's Ninja generator
This fixes compatibility with
Ninja
generator