-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unseeded LBP PoC #1169
Closed
Closed
Unseeded LBP PoC #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pkg/pool-utils/contracts/controllers/BasePoolController.sol # pvt/helpers/src/models/pools/weighted/WeightedPoolDeployer.ts
# Conflicts: # pvt/helpers/src/models/types/TypesConverter.ts
Deprioritized for now. Archive for future reference. |
# Conflicts: # pvt/helpers/src/models/pools/weighted/WeightedPool.ts # pvt/helpers/src/models/pools/weighted/WeightedPoolDeployer.ts # pvt/helpers/src/models/pools/weighted/types.ts # pvt/helpers/src/models/types/TypesConverter.ts
Closed
De-prioritized for now. It's at a decent stopping point; Notion doc under contracts details future plans. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoC LiquidityBootstrappingPool that requires no capital. (I left the original LiquidityBootstrappingPool and factory in place, to not break the tests.)
The underlying pool is limited to two tokens, and pays protocol fees in BPT (so far, we need this anyway). It also allows the reserve token to have an asset manager.
There is a pool controller (derived from BaseController, so the manager is transferrable, etc.), which doubles as the asset manager.
There are two factories: SeededLiquidityBootstrappingPoolFactory just deploys the new pool type - but hard-codes the asset manager to zero, and sets the owner to be the deployer: no controller, just a normal LBP, funded in the usual way that requires capital.
UnseededLiquidityBootstrappingPoolFactory creates an AssetManagedLiquidityBootstrappingPoolController, and wires it up to a new AssetManagedLiquidityBootstrappingPool, so that the controller is both the pool owner and reserve token asset manager. (The manager of the pool controller is passed in.)
The result will be an apparently fully funded LBP, but with zero cash balance, so that tokens cannot be "sold back" at first.
Resolves #1520.