Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: move Version to solidity-utils. #2525

Merged
merged 5 commits into from
Jun 21, 2023
Merged

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented Jun 21, 2023

Description

Moving Version to solidity utils (just a refactor).
We are already using it outside pools, and we'll use it for the relayer as well.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb June 21, 2023 15:04
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one suggestion for the changelogs; otherwise LGTM.

pkg/pool-utils/CHANGELOG.md Outdated Show resolved Hide resolved
@jubeira jubeira merged commit 872342e into master Jun 21, 2023
16 checks passed
@jubeira jubeira deleted the refactor-version-sol-utils branch June 21, 2023 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants