Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Optimism --> Optimistic gauges, with public network tag. #2565

Merged
merged 2 commits into from
May 31, 2024

Conversation

jubeira
Copy link
Contributor

@jubeira jubeira commented May 30, 2024

Description

In response to balancer/balancer-deployments#117 (comment); it might get confusing if we keep adding L2s that are OP-stack compatible.

This minor refactor changes the contract name and adds a public tag to identify the target L2 in the gauge and the factory.

Type of change

  • Bug fix
  • New feature
  • Breaking change
  • Dependency changes
  • Code refactor / cleanup
  • Documentation or wording changes
  • Other

Checklist:

  • The diff is legible and has no extraneous changes
  • N/A Complex code has been commented, including external interfaces
  • N/A Tests are included for all code paths
  • The base branch is either master, or there's a description of how to merge

Issue Resolution

N/A

@jubeira jubeira requested a review from EndymionJkb May 30, 2024 13:50
Copy link
Collaborator

@EndymionJkb EndymionJkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea - it's a more general solution that avoids the name clash but also doesn't require a new factory for every network.

I guess CI is just failing because of the settings?

@jubeira jubeira merged commit 281e98f into master May 31, 2024
10 of 16 checks passed
@jubeira jubeira deleted the optimistic-gauges branch May 31, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants