clean up / clarify usage of HOST_IP in geth_entrypoint #272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…peer connectivity and otherwise use default --nat value
danyalprout
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously HOST_IP was defaulting to 0.0.0.0, and being exposed via --nat as an external IP address. This PR makes HOST_IP default to empty, in which case no --nat flag will be used (implying the "any" geth default will be active). Adds a comment that HOST_IP should be set to external IP address and port 30303 opened to improve connectivity, in which case the --nat flag will be set to
extip:$HOST_IPThis potentially explains #222