Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update pinata package to pinata-web3 #976

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stevedylandev
Copy link

What changed? Why?

I've updated the Pinata SDK package to use the pinata-web3 instead of the original SDK which no longer supports IPFS

Notes to reviewers

This is a direct fork of the original Pinata SDK that was originally included in the app

How has it been tested?

I have not tested this app specifically but the pinata-web3 package is working exactly as [email protected]

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
base-web 🛑 Canceled (Inspect) Sep 20, 2024 1:38pm
web-base-docs ❌ Failed (Inspect) Sep 20, 2024 1:38pm

Copy link

vercel bot commented Sep 3, 2024

@stevedylandev is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@kirkas
Copy link
Collaborator

kirkas commented Sep 10, 2024

@stevedylandev Thanks for your PR & suggestion.

What are the benefits of pinata-web3 over pinata?

AFAICS the differences between the two are:

  • pinata-web3 has a slightly different README.md
  • pinata-web3 is 59 commit behind pinata

@stevedylandev
Copy link
Author

Hey @kirkas!

Thanks for responding! I'm actually the maintainer of both. The pinata package had a v1 breaking change where it only uses our new Files API. This API is similar to our traditional IPFS API but it does not actually use public IPFS. The pinata-web3 package was a fork before the v1 release and maintains the IPFS APIs. Any further changes to our IPFS SDK will be made in that package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants