Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't kick if data rate is at threshold #232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

HarvsG
Copy link

@HarvsG HarvsG commented Sep 15, 2023

Fixes #231

@Flole998
Copy link
Contributor

@PolynomialDivision Can this be merged please?

@PolynomialDivision
Copy link
Collaborator

I don't understand the benefit? You can just set the threshold to a higher value and it has the same effect?

@Flole998
Copy link
Contributor

I just checked the docs again and they describe the current behaviour. However, the log entry is misleading then as it says "below" while it should say "at or below". @HarvsG What do you think about just changing the log message?

@HarvsG
Copy link
Author

HarvsG commented Oct 26, 2023

Current behaviour is broken, because the default setting is a commonly used data rate, so clients are kicked uneccessarily

@teohhanhui
Copy link

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

// <= 6MBits <- probably no transmission

@HarvsG
Copy link
Author

HarvsG commented Jun 15, 2024

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

I don't think it's a safe assumption because some IoT devices do transmit at that data rate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DAWN kicks clients with good bitrates
4 participants