tweak(adminPanel): RN-1419: Don't delete survey screens and components on import unless they have changed #5885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
reviewed
Sep 12, 2024
| @@ -23,10 +23,16 @@ import { | |||
| SURVEY_METADATA, | |||
| } from './processSurveyMetadata'; | |||
| import { caseAndSpaceInsensitiveEquals, convertCellToJson } from './utilities'; | |||
| import { RECORDS } from '@tupaia/database'; | |||
There was a problem hiding this comment.
Suggested change
| import { RECORDS } from '@tupaia/database'; |
tcaiger
reviewed
Sep 12, 2024
| const objectsAreEqual = (a, b) => { | ||
| if (!!a === !!b) return true; | ||
| return JSON.stringify(a) === JSON.stringify(b); | ||
| }; |
There was a problem hiding this comment.
I don't think this function is always going to be correct. I would probably just outsource this to lodash isEqual here since we need to do a deep equality check?! Or if you update the function it would probably be good to add a unit test for it
tcaiger
requested changes
Sep 12, 2024
tcaiger
approved these changes
Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue RN-1419: Don't delete survey screens and components on import unless they have changed
Changes:
importSurveyQuestionsto only update relevant fields in the survey screen component