Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue of GSP-970: Service Factory #975

Closed
1 of 2 tasks
Xuanwo opened this issue Oct 28, 2021 · 8 comments
Closed
1 of 2 tasks

Tracking issue of GSP-970: Service Factory #975

Xuanwo opened this issue Oct 28, 2021 · 8 comments
Assignees
Labels
tracking/gsp Tracking the implemetation of a GSP

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Oct 28, 2021

Steps

@Xuanwo Xuanwo added the tracking/gsp Tracking the implemetation of a GSP label Oct 28, 2021
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 2, 2021

The definitions have been refactored, we can build factory now.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 10, 2021

Let's migrate all services to factory! @Joey2132, take #997 as reference.

@Joey2132
Copy link
Contributor

Joey2132 commented Nov 10, 2021

Let's migrate all services to factory! @Joey2132, take #997 as reference.

Got it. Maybe we should list all services like issue #868 does?

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 10, 2021

Updated.

@Joey2132
Copy link
Contributor

Updated.

Got it. After adding test upon minio for s3, I will start to handle it.

@Xuanwo
Copy link
Contributor Author

Xuanwo commented Nov 10, 2021

@Joey2132 How about creating a comment yourself so that you can maintain the working progress?

@Joey2132
Copy link
Contributor

How about creating a comment yourself so that you can maintain the working progress?

Yes. In this way, I can update it by myself. So please delete it in your description. I will create another one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tracking/gsp Tracking the implemetation of a GSP
Projects
Status: Done
Development

No branches or pull requests

2 participants