Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADAM-2127] Update python doc per GenomicRdd --> GenomicDataset change #2128

Merged
merged 1 commit into from
Mar 1, 2019

Conversation

heuermh
Copy link
Member

@heuermh heuermh commented Feb 25, 2019

Fixes #2127

@heuermh heuermh added this to the 0.27.0 milestone Feb 25, 2019
@akmorrow13
Copy link
Contributor

This LGTM. Also you were right @heuermh , this will need to be updated on pypi for the changes on readthedocs to be updated. I was looking into this issue last week, but it looks like all the API links on readthedocs are broken . They are incorrectly linking to a folder (overview/) when they should link to api/python.html. I have not been able to replicate this issue on my local computer.

@heuermh
Copy link
Member Author

heuermh commented Feb 25, 2019

Bummer. We can merge this and #2126 then, and if/when we come up with a fix for #2131, push the 0.26.0a0 release to PyPI.

@AmplabJenkins
Copy link

Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/ADAM-prb/2947/
Test PASSed.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 79.075% when pulling 58cd636 on heuermh:issue-2127 into c3324d2 on bigdatagenomics:master.

@heuermh heuermh merged commit 9362f15 into bigdatagenomics:master Mar 1, 2019
@heuermh
Copy link
Member Author

heuermh commented Mar 1, 2019

Thank you for the review, @akmorrow13

@heuermh heuermh deleted the issue-2127 branch March 1, 2019 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants