Support DataKinds #54
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roelvandijk
added a commit
to LumiGuide/haskell-opencv
that referenced
this pull request
May 21, 2016
- Removed dependency on custom version of haskell-src-meta - Can be undone once issue with haskell-src-meta is resolved (bmillwood/haskell-src-meta#54)
|
@roelvandijk I've taken over the package. This PR is very old and currently has a merge conflict, so I've not attempted to pull it into the new release yet. (Well, I did attempt it, but I ran into issues with ghc complaining about the DataKinds pragma not being there, even though it was there, so I abandoned my efforts for now.) If you'd like to open a fresh PR on the forked repo, please feel free. https://github.com/DanBurton/haskell-src-meta |
|
We just copy+pasted that module into our project: https://github.com/LumiGuide/haskell-opencv/blob/master/doc/Language/Haskell/Meta/Syntax/Translate.hs It has received some patches in the last 3 years. Feel free to use it for inspiration, or just copy+paste it back into haskell-src-meta. If I have some free time I could take a look at the differences between both files and maybe make a nice up-to-date pull request. |
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 6, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 6, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
|
Relevant fix: haskell-party#3 (comment) I found that handling So by simply fixing all I guess whether to keep this issue open depends on whether you'd like to support the (now-legacy) |
5 tasks
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 6, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 7, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 29, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
nh2
added a commit
to nh2/haskell-opencv
that referenced
this pull request
Sep 29, 2023
The main task here is to make `doc-images-opencv` work, which is this package's way to generate nice documentation images into the Haddocks, from code that's in the Haddocks. For that, this commit: * Deletes copy-pasted + modified module from `haskell-src-meta`, `Language.Haskell.Meta.Syntax.Translate`, since as per the commit mentioned in * bmillwood/haskell-src-meta#54 * haskell-party/haskell-src-meta#3 (comment) * haskell-party/haskell-src-meta@5c69c3a the necessary `DataKinds` changes were merged upstream. The commit suggests it's in >= 0.8.3, so that's what's added in the `.cabal` file. * Replaces all occurrences of `*` by `Type` from `Data.Kind` to fix all `-Wstar-is-type` warnings (see also https://ghc-proposals.readthedocs.io/en/latest/proposals/0143-remove-star-kind.html). This is necessary because the upstream `haskell-src-meta` above does not support `*` but does support `Type`; it would print: Language.Haskell.Meta.Syntax.Translate.toType: not implemented: TyStar ()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Necessary if you want to translate Haskell code using the DataKinds language extension.
Note that a small hack was needed to translate a HSE KindVar to template haskell. HSE does not seem to be able to distinguish between kind variables (such as 'k') and kind constructors (such as 'Nat').