Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add help buttons for different views #5852

Merged
merged 7 commits into from
Oct 31, 2023

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Oct 29, 2023

See #5849

The goal of this PR is to make it easier to get context sensitive help inside Bndtools using "help" buttons to each View linking to the relevant sections of the manual.

Each button should also have a helpful tooltip summarizing the basic concept of the view ideally being helpful already. A click should open the webbrowser with the relevant page.

This would bridge the gap between Eclipse and the manual and allow us to improve especially those entry-pages in the manual, since we now know they are most likely clicked from bndtools in Eclipse.

Current status of this PR

I provided the following Help buttons:

Bndtools Explorer

image

Link: https://bndtools.org/manual/packageexplorer.html

Repositories View

image

Link: https://bndtools.org/manual/repositories-view.html

Resolution View

image

Link: https://bndtools.org/manual/resolution-view.html

Bnd Editor for bnd.bnd files

image

Link: https://bndtools.org/manual/bndeditor.html

Bnd Editor for .bndrun files

image

Link: https://bndtools.org/manual/bndeditor.html#run

Workspace Bnd Editor e.g. cnf/build.bnd

image

Link: https://bndtools.org/manual/bndeditor.html

Welcome Screen

Now the following sections of the Eclipse Welcome Screen contain a Bndtools relevant entry linking to a page on the bndtools.org website

image

Icons
The help icon is currently from Eclipse internally and might be a bit big. But maybe this is a good thing, as it catches the eye more.
If you can tell me where to get a better icon which is allowed to be used, please let me know. @pkriens

@chrisrueger
Copy link
Contributor Author

Setting to Draft PR again because I will add the -runbundles required for Eclipse Welcome / Intro screen and add some entries for Bndtools there. see #5853

@pkriens
Copy link
Member

pkriens commented Oct 30, 2023

If you can tell me where to get a better icon which is allowed to be used, please let me know. @pkriens

If you can find a better icon with open source use, just add it to the bndtools.core properties, see org.bndtools.core.ui.icons.Icons class. You could also scale them.

I thought we had a list of open source projects we used in bndtools but can't find it anymore. Maybe time to add it.

HELP_BTN_REPOSITORIES, HELP_BTN_BNDTOOLS_EXPLORER, HELP_BTN_RESOLUTION_VIEW

Signed-off-by: Christoph Rueger <[email protected]>
* add Bndtools to Overview and Tutorials and link to relevant pages on bndtools.org
* before this change there was already an entry in the Whats new section, but usually the Overview is the first thing shown. So I added it to the overview too to have more visibility for bndtools

Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger
Copy link
Contributor Author

I thought we had a list of open source projects we used in bndtools but can't find it anymore. Maybe time to add it.

Maybe you mean this in the main README?
image

e.g. for the main cnf/build.bnd

Signed-off-by: Christoph Rueger <[email protected]>
* the resolver now adds the same bundles which I aded manually in an earlier commit. I verified.. files are exactly the same.

Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger chrisrueger marked this pull request as ready for review October 30, 2023 14:48
@chrisrueger
Copy link
Contributor Author

I think I am done so far. Would be glad to get feedback.
I updated the PR description with screenshots of the touched editors / views.

Copy link
Member

@pkriens pkriens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am ok to merge

bndtools.core/src/bndtools/editor/common/Buttons.java Outdated Show resolved Hide resolved
implement suggested changes (rename classes, move to method to util class)

Signed-off-by: Christoph Rueger <[email protected]>
@pkriens pkriens merged commit 2964e9f into bndtools:master Oct 31, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants