Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade gradle wrapper from 8.1.1 to 8.10.1 in order to build with Java 22 #6280

Merged
merged 2 commits into from
Sep 19, 2024

Conversation

chrisrueger
Copy link
Contributor

@chrisrueger chrisrueger commented Sep 19, 2024

Based on a discussion in #6271 @reckart needed to upgrade gradle wrapper in order to build with Java 22.
Basically what was done is documented here: https://github.com/bndtools/bnd/blob/master/CONTRIBUTING.md#gradle-wrapper

This is an attempt to do so.
https://docs.gradle.org/8.10.1/release-notes.html

@pkriens I am unsure about the addition in TestHelper.groovy. Is this correct? Not sure what the intention of that method is.

just noticed there is 8.10.1 already

Signed-off-by: Christoph Rueger <[email protected]>
@chrisrueger chrisrueger changed the title upgrade gradle wrapper from 8.1.1 to 8.10 in order to build with Java 22 upgrade gradle wrapper from 8.1.1 to 8.10.1 in order to build with Java 22 Sep 19, 2024
@chrisrueger
Copy link
Contributor Author

Just noticed this deprecation warning in the log of Validate Gradle Wrapper action

Warning: This job uses deprecated functionality from the 'gradle/wrapper-validation-action' action. Consult the logs for more details.
DEPRECATION: The action gradle/wrapper-validation-action has been replaced by gradle/actions/wrapper-validation. See https://github.com/gradle/actions/blob/main/docs/deprecation-upgrade-guide.md#the-action-gradlewrapper-validation-action-has-been-replaced-by-gradleactionswrapper-validation

I will look into this later

@chrisrueger
Copy link
Contributor Author

@pkriens imo this can be merged. The deprecated GitHub action can be done separately.

@pkriens
Copy link
Member

pkriens commented Sep 19, 2024

I am gonna trust you :-)

@pkriens pkriens merged commit ba2cd56 into bndtools:master Sep 19, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants