Skip to content

Commit

Permalink
Adds PIC for shared object builds
Browse files Browse the repository at this point in the history
  • Loading branch information
JerrySievert committed Jul 10, 2023
1 parent 403e0d0 commit 82055ea
Showing 1 changed file with 17 additions and 0 deletions.
17 changes: 17 additions & 0 deletions CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -112,6 +112,12 @@ set(enable-exceptions
$<$<CXX_COMPILER_ID:GNU>:-fexceptions>
)

set(enable-fPIC
$<$<CXX_COMPILER_ID:AppleClang>:-fPIC>
$<$<CXX_COMPILER_ID:Clang>:-fPIC>
$<$<CXX_COMPILER_ID:GNU>:-fPIC>
)

#
# d8
#
Expand All @@ -130,6 +136,7 @@ add_executable(

target_compile_definitions(d8 PRIVATE $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(d8 PRIVATE ${disable-exceptions})
target_compile_options(d8 PRIVATE ${enable-fPIC})

target_include_directories(d8
PUBLIC
Expand Down Expand Up @@ -436,6 +443,7 @@ set_property(SOURCE v8/src/diagnostics/unwinding-info-win64.cc

target_compile_definitions(v8_base_without_compiler PRIVATE ${v8_defines} $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_base_without_compiler PRIVATE ${disable-exceptions})
target_compile_options(v8_base_without_compiler PRIVATE ${enable-fPIC})

target_include_directories(v8_base_without_compiler
PRIVATE
Expand Down Expand Up @@ -469,6 +477,7 @@ add_library(v8_compiler STATIC)
target_sources(v8_compiler PRIVATE ${compiler-sources})
target_compile_definitions(v8_compiler PRIVATE ${v8_defines} $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_compiler PRIVATE ${disable-exceptions})
target_compile_options(v8_compiler PRIVATE ${enable-fPIC})

target_include_directories(v8_compiler
PUBLIC
Expand Down Expand Up @@ -547,6 +556,7 @@ add_library(

target_compile_definitions(v8_initializers PRIVATE ${v8_defines} $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_initializers PRIVATE ${disable-exceptions})
target_compile_options(v8_initializers PRIVATE ${enable-fPIC})

target_include_directories(v8_initializers
PRIVATE
Expand All @@ -571,6 +581,7 @@ add_library(

target_compile_definitions(v8_snapshot PRIVATE $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_snapshot PRIVATE ${disable-exceptions})
target_compile_options(v8_snapshot PRIVATE ${enable-fPIC})
target_include_directories(v8_snapshot PRIVATE ${PROJECT_SOURCE_DIR}/v8)

target_link_libraries(v8_snapshot
Expand Down Expand Up @@ -652,6 +663,7 @@ add_library(v8_inspector STATIC

target_compile_features(v8_inspector PUBLIC cxx_std_17)
target_compile_options(v8_inspector PRIVATE ${disable-exceptions})
target_compile_options(v8_inspector PRIVATE ${enable-fPIC})
target_compile_definitions(v8_inspector PUBLIC $<${is-msvc}:_HAS_EXCEPTIONS=0>)

target_include_directories(v8_inspector
Expand Down Expand Up @@ -722,6 +734,8 @@ target_sources(v8_libplatform

target_compile_definitions(v8_libplatform PRIVATE $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_libplatform PRIVATE ${disable-exceptions})
target_compile_options(v8_libplatform PRIVATE ${enable-fPIC})

target_include_directories(v8_libplatform
PUBLIC
${PROJECT_SOURCE_DIR}/v8/include
Expand All @@ -745,6 +759,7 @@ target_include_directories(v8_libsampler

target_compile_definitions(v8_libsampler PRIVATE $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_libsampler PRIVATE ${disable-exceptions})
target_compile_options(v8_libsampler PRIVATE ${enable-fPIC})
target_include_directories(v8_libsampler PRIVATE ${PROJECT_SOURCE_DIR}/v8)
target_link_libraries(v8_libsampler PRIVATE v8_libbase)

Expand Down Expand Up @@ -793,6 +808,7 @@ set_property(SOURCE v8/src/base/utils/random-number-generator.cc

target_compile_definitions(v8_libbase PRIVATE $<${is-win}:UNICODE> $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_libbase PRIVATE ${disable-exceptions})
target_compile_options(v8_libbase PRIVATE ${enable-fPIC})
target_include_directories(v8_libbase PRIVATE ${PROJECT_SOURCE_DIR}/v8)
target_link_libraries(v8_libbase
PRIVATE
Expand Down Expand Up @@ -925,6 +941,7 @@ add_library(

target_compile_definitions(v8_torque_generated PRIVATE $<${is-msvc}:_HAS_EXCEPTIONS=0>)
target_compile_options(v8_torque_generated PRIVATE ${disable-exceptions})
target_compile_options(v8_torque_generated PRIVATE ${enable-fPIC})
target_link_libraries(v8_torque_generated PRIVATE v8-bytecodes-builtin-list)

target_include_directories(v8_torque_generated
Expand Down

0 comments on commit 82055ea

Please sign in to comment.