Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: windows build (#73,#67) #74

Closed
wants to merge 1 commit into from

Conversation

CGQAQ
Copy link

@CGQAQ CGQAQ commented Jul 20, 2023

fix Windows build by limiting single custom command length,

Touch 200 files per command on Windows now, it's half of the total files which is around 440s

Closes: #73
Closes: #67

@CGQAQ
Copy link
Author

CGQAQ commented Jul 21, 2023

@bnoordhuis pls take a look

@bnoordhuis
Copy link
Owner

It's failing with "unresolved external symbol" and I kind of expected that it would. Torque is, to the best of my understanding, a closed-world compiler (i.e., needs to see all inputs) and therefore not amenable to a staggered approach.

I think the best way to approach this is by teaching torque to read from a resource file (a file that lists all the inputs) but that patch should be sent to upstream V8 first if the diff is more than a few lines because I don't want to carry complex patches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can not build d8 on Windows 11 v8-cmake fails to build torque
2 participants