Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for resolving users with aliases #3432

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

hughrun
Copy link
Contributor

@hughrun hughrun commented Sep 8, 2024

Description

Adds a test to ensure resolving remote IDs when a user has an alsoKnownAs entry is resolved properly.

In #3426 I thought there was a problem, but this test shows that there is not. So I think what I was seeing is when the remote id can't be reached.

What type of Pull Request is this?

  • Bug Fix
  • Enhancement
  • Plumbing / Internals / Dependencies
  • Refactor

Does this PR change settings or dependencies, or break something?

  • This PR changes or adds default settings, configuration, or .env values
  • This PR changes or adds dependencies
  • This PR introduces other breaking changes

Details of breaking or configuration changes (if any of above checked)

Documentation

  • New or amended documentation will be required if this PR is merged
  • I have created a matching pull request in the Documentation repository
  • I intend to create a matching pull request in the Documentation repository after this PR is merged

Tests

  • My changes do not need new tests
  • All tests I have added are passing
  • I have written tests but need help to make them pass
  • I have not written tests and need help to write them

@hughrun
Copy link
Contributor Author

hughrun commented Sep 8, 2024

LOL well I guess all the failing tests kind of prove the point.

Will fix this in a bit.

Instead of breaking a bunch of existing tests...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

activitypub.resolve_remote_id throws IntegrityError if remote user has unknown alias
1 participant